Changeset 811 for branches

Timestamp:

09/04/07 03:29:58 (5 years ago)

Author:

wd

Message:

Fix long-standing PING bug by doing a special check for (effectively) local
client pings.

File:

• branches/ithildin-1.1/modules/ircd/commands/ping.c (modified) (2 diffs)

branches/ithildin-1.1/modules/ircd/commands/ping.c

@@ -32 +32 @@
     }
 
-    /* sp is now set to our destination.  cli is our origin. */
+    /* sp is now set to our destination.  cli is our origin.
+     * Note that in the first case we return whatever the client sends in
+     * argv[1] since some clients rely on this behavior. */
     if (sp == ircd.me)
         sendto_one_target(cli, NULL, ircd.me, NULL, "PONG", "%s :%s",
-                ircd.me->name, cli->nick);
+                ircd.me->name, argv[1]);
     else
         sendto_serv_from(sp, cli, NULL, NULL, "PING", "%s :%s", cli->nick,
@@ -52 +54 @@
         return 0;
 
-    /* sp is now set to our destination.  cli is our origin. */
+    /* sp is now set to our destination.  srv is our origin. */
     if (sp == ircd.me)
         sendto_serv_from(srv, NULL, ircd.me, NULL, "PONG", "%s :%s",